Remove unneeded dependency on X11 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on FreeBSD, this is not needed.
|
Yes, we dont need this one any more, all related code was removed from the game, since SDL2 have all we need now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on FreeBSD, this is not needed.
Even if it's needed on Linux, it's used incorrectly, as X11_LIBRARIES would link with libX11 + any other X11 libs it can find (e.g. libXext, libSM, libICE, etc.). This hinders reproducible builds, creates needless dependencies and slows down app startup.
This change must be tested on Linux, and if it turns out to break the build, it could be redone with explicit list of X libs (e.g.
${X11_X11_LIB}instead of${X11_LIBRARIES})