Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate comments in game folder #23

Closed
wants to merge 1 commit into from
Closed

Translate comments in game folder #23

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2020

This change contains translations of comments in game.cpp and game_player_ship.cpp files in game folder. The remaining source files in the folder are already translated.

@claassistantio
Copy link

claassistantio commented Jan 6, 2020

CLA assistant check
All committers have signed the CLA.

@@ -477,32 +475,32 @@ void DrawGame()


//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
// Работа с 3д частью... прорисовка, просчет
// 3D work - drawing, rendering
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not drawing mean the same as rendering? I thought this is almost the same.

int X = GameConfig().InternalWidth / 2 - 192;
Y = 545;
// продолжение игры
// contonue the game
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue?

case 3:
return 50.0f;
// отражатель
// reflector
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In variable names and comments I usually use deflector word, probably, we should stay with one term, or change it everywhere.

@@ -1127,9 +1124,9 @@ void GamePlayerShip()
}
}
break;
// отражатель
// reflector
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In variable names and comments I usually use deflector word, probably, we should stay with one term, or change it everywhere.

@@ -537,15 +534,15 @@ void GamePlayerShip()


//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
// Вывод голосового предупреждения, если в оружие нет пуль
// Output voice warning if weapon has no munition
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ammunition/ammo?

for (const auto &tmpWeaponSlot : sharedPlayerFighter->WeaponSlots) {
// если нажали стрелять, а патронов нет в одном из орудий
// if fire button is pressed and one weapon has no munition
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ammunition/ammo?

if (sharedWeapon->ArmorCurrentStatus <= 0.0f) {
ChangeGameConfig().Profile[CurrentProfile].WeaponAmmo[i] = 0;
ChangeGameConfig().Profile[CurrentProfile].Weapon[i] = 0;
} else {
// если все ок, нужно запомнить сколько осталось в боекомплекте
// if all is good, should store remaining munitions
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ammunition/ammo?

//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
// сейчас получаем всю энергию для перезарядки и выстрела
// потом лучше будет переделать на постепенный отбор энергии
// now receiving all energy for recharging and firing
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, should be marked as TODO.

@viewizard
Copy link
Owner

Looks like no fixes will be available for this PR, close it for now.

@viewizard viewizard closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants