Some tests failing on newer php

violinist-dev · Sep 10, 2024 · 5bed579 · 5bed579
1 parent feed814
commit 5bed579
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/tests/Integration/PackageToCheckTest.php b/tests/Integration/PackageToCheckTest.php
@@ -15,6 +15,9 @@ protected function createUpdater($directory)
         if (version_compare(phpversion(), "7.3.0", "<")) {
             self::expectException(ComposerUpdateProcessFailedException::class);
         }
+        if (version_compare(phpversion(), "8.3.0", ">=")) {
+            self::expectException(ComposerUpdateProcessFailedException::class);
+        }
         $updater = new Updater($directory, 'drupal/recaptcha');
         $updater->setPackageToCheckHasUpdated($this->package);
         return $updater;

diff --git a/tests/Integration/RequireTest.php b/tests/Integration/RequireTest.php
@@ -16,6 +16,9 @@ public function testEndToEnd()
         if (version_compare(phpversion(), "8.0.0", "<")) {
             $this->expectException(NotUpdatedException::class);
         }
+        if (version_compare(phpversion(), "8.3.0", ">=")) {
+          self::expectException(NotUpdatedException::class);
+        }
         parent::testEndToEnd();
     }
 }
diff --git a/tests/Integration/UpdateSecondTryTest.php b/tests/Integration/UpdateSecondTryTest.php
@@ -16,6 +16,9 @@ public function testEndToEnd()
         if (version_compare(phpversion(), "8.0.0", "<")) {
             return;
         }
+        if (version_compare(phpversion(), "8.3.0", ">=")) {
+            return;
+        }
         parent::testEndToEnd();
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,9 @@ public function testEndToEnd() @@
             if (version_compare(phpversion(), "8.0.0", "<")) {
                 return;
             }
+            if (version_compare(phpversion(), "8.3.0", ">=")) {
+                return;
+            }
             parent::testEndToEnd();
         }
@@ Expand Down @@