feat: add mysql 8.4 docker images

[L3o-pold]

Description

Add MySQL8.4 docker images

Related Issue(s)

Fixes #17519

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (db4fca3) to head (24589d6).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
go/tools/go-upgrade/go-upgrade.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17529   +/-   ##
=======================================
  Coverage   67.68%   67.69%           
=======================================
  Files        1584     1584           
  Lines      254630   254720   +90     
=======================================
+ Hits       172356   172422   +66     
- Misses      82274    82298   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbussink]

One question for @frouioui, otherwise looks good to me.

[dbussink]

@frouioui Do we need to bump this to 42 now that we add this new image?

[L3o-pold]

For me we don't as we add a new image and we are not editing a new one, but it's only my opinion.

[frouioui]

Yeah I don't think we should bump it to 42. We will just build the new (mysql84) tag for 41.

[frouioui]

I have built and pushed the new :41-mysql84 tag for the bootstrap image: https://hub.docker.com/repository/docker/vitess/bootstrap/tags/41-mysql84/sha256-274e1d113b6ea8616a253155cf7c8206aaf2d695f14018c6109c97e6c4c8318b

[frouioui]

The docker build looks good to me:

root@vitess-testing:~/vitess# make docker_lite_mysql84
Building vitess/lite:mysql84
...
...
 => => exporting layers                                                                                                                                                                                    6.1s 
 => => writing image sha256:34c5e32d982a5165e23d775284b1f89118244d522f8e9f49b701465849a60781                                                                                                               0.0s 
 => => naming to docker.io/vitess/lite:mysql84                                                                                                                                                             0.0s 
root@vitess-testing:~/vitess#    

[frouioui]

Looks good to me! Thanks a bunch for working on this @L3o-pold ❤️

[frouioui]

Before merging, quick question, were you able to verify that the new image fixes the bug you described in #17519?

Edit: It should be okay, but may as well double check.

root@vitess-testing:~/vitess# docker run -it docker.io/vitess/lite:mysql84 bash                                                                                                                                 
vitess@9ea46cf53580:/$ xtrabackup --version 
2025-01-21T15:02:15.851047-00:00 0 [Note] [MY-011825] [Xtrabackup] recognized server arguments: --datadir=/var/lib/mysql 
xtrabackup version 8.4.0-2 based on MySQL server 8.4.0 Linux (x86_64) (revision id: d4373834)
vitess@9ea46cf53580:/$ 

[L3o-pold]

I don't, we rollbacked to 8.0 as 8.4 is experimental in Vitess

[GrahamCampbell]

It looks like this has the wrong version of Golang, causing builds to fail. See #17601.