-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemadiff
: validate uniqueness of CHECK
and of FOREIGN KEY
constraints
#17627
Open
shlomi-noach
wants to merge
4
commits into
vitessio:main
Choose a base branch
from
planetscale:schemadiff-constraint-uniqueness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
schemadiff
: validate uniqueness of CHECK
and of FOREIGN KEY
constraints
#17627
shlomi-noach
wants to merge
4
commits into
vitessio:main
from
planetscale:schemadiff-constraint-uniqueness
+95
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: schema management
schemadiff and schema changes
labels
Jan 26, 2025
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 26, 2025
shlomi-noach
changed the title
Jan 26, 2025
schemadiff
: validate uniqueness of CHECK and of FOREIGN KEY constraintsschemadiff
: validate uniqueness of CHECK
and of FOREIGN KEY
constraints
shlomi-noach
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsWebsiteDocsUpdate
What it says
labels
Jan 26, 2025
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17627 +/- ##
==========================================
- Coverage 67.64% 67.62% -0.02%
==========================================
Files 1586 1586
Lines 255629 255647 +18
==========================================
- Hits 172910 172882 -28
- Misses 82719 82765 +46 ☔ View full report in Codecov by Sentry. |
mattlord
approved these changes
Jan 26, 2025
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
dbussink
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: schema management
schemadiff and schema changes
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds schema-scope validations:
CHECK
constraints have the same name.FOREIGN KEY
constraints have the same name.Note: there is no problem for a
CHECK
constraint and for aFOREIGN KEY
constraint to have the same name.These validations are compliant with MySQL and are required, as MySQL strictly enforces this uniqueness.
Related Issue(s)
Checklist
Deployment Notes