Improve vCenter refresh stability in tests by using runWithRetry #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Didainius
changed the title
adambarreiro
approved these changes
Jan 27, 2025
lvirbalas
reviewed
Jan 27, 2025
lvirbalas
approved these changes
Jan 27, 2025
lvirbalas
requested changes
Jan 27, 2025
| var maximumVcenterRetryTime = 120 * time.Second // The maximum time a single operation will be retried before giving up | ||
| var vCenterEntityBusyRegexp = regexp.MustCompile(`(is currently busy|400|BUSY_ENTITY)`) // Regexp to match entity busy error | ||
|
|
||
| func runWithRetry(runOperation func() error, errRegexp *regexp.Regexp, duration time.Duration) error { |
There was a problem hiding this comment.
We decided to pull this logic out of tests, and out of Terraform provider level https://github.com/vmware/terraform-provider-vcfa/pull/11/files#diff-f4455ddd79cb9237ff3f5c05d6d2c74431b01fa40dd231c43adcc48a00e419c0
We'll move to SDK level instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test improvements only:
This PR enables retry of vCenter "refresh" and "refresh policies" operations for testing. It also removes some of the "sleep" behavior for tests.