-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create docker build action #663
base: master
Are you sure you want to change the base?
create docker build action #663
Conversation
thanks, |
|
||
env: | ||
# Use docker.io for Docker Hub if empty | ||
REGISTRY: ghcr.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
down below the password is set to secrets.GITHUB_TOKEN
so here no real change possible. I think the project should choose on registry (ghcr.io is fine) and remove this from env.
# multi-platform images and export cache | ||
# https://github.com/docker/setup-buildx-action | ||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 # v3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the sha is not done for the other github actions. Having here sha makes this without a dependabot or renovate hard to maintain. Do not know what the best solution is.
id: build-and-push | ||
uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0 | ||
with: | ||
context: . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use checkout and context instead of the default git access of buildx?
Since my PR is 3 years old, I am totally fine to replace it with a modern approach. |
i'm not fluent in github pipeline definitons so it's not easy for me to review this. |
ping @guidoffm |
What you can do: Go to the "Actions tab". Then hit the button "New Workflow". Then choose the template "Publish Docker Container" and hit the "Configure" button. |
How can I help to get build action implemented? |
@oeiber: personally i'm no expert on this and it's not a priority for me. |
Create a GitHub action that does a multi platform Docker build and publishes the image to GitHub