Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create docker build action #663

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

guidoffm
Copy link

Create a GitHub action that does a multi platform Docker build and publishes the image to GitHub

@r00t-
Copy link
Contributor

r00t- commented Jun 18, 2024

thanks,
can you say how this compares to #478 ?
(that one has been stalled, not sure why right now.)

@guidoffm guidoffm mentioned this pull request Jun 18, 2024
@guidoffm
Copy link
Author

thanks, can you say how this compares to #478 ? (that one has been stalled, not sure why right now.)

I have commented in #478


env:
# Use docker.io for Docker Hub if empty
REGISTRY: ghcr.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

down below the password is set to secrets.GITHUB_TOKEN so here no real change possible. I think the project should choose on registry (ghcr.io is fine) and remove this from env.

# multi-platform images and export cache
# https://github.com/docker/setup-buildx-action
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 # v3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the sha is not done for the other github actions. Having here sha makes this without a dependabot or renovate hard to maintain. Do not know what the best solution is.

id: build-and-push
uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0
with:
context: .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use checkout and context instead of the default git access of buildx?

@StefanSchoof
Copy link
Contributor

Since my PR is 3 years old, I am totally fine to replace it with a modern approach.

@r00t-
Copy link
Contributor

r00t- commented Jun 24, 2024

i'm not fluent in github pipeline definitons so it's not easy for me to review this.
guessing from from the boilerplate comments, your workflow definition seems to be created based on some example, can you link that?
(or even commit the original and then your changes on top?)

@r00t-
Copy link
Contributor

r00t- commented Jul 12, 2024

ping @guidoffm

@guidoffm
Copy link
Author

What you can do:

Go to the "Actions tab". Then hit the button "New Workflow". Then choose the template "Publish Docker Container" and hit the "Configure" button.

@oeiber
Copy link
Contributor

oeiber commented Dec 17, 2024

How can I help to get build action implemented?

@r00t-
Copy link
Contributor

r00t- commented Dec 18, 2024

@oeiber:
you could address any of the comments above, either by commenting with suggestions here, or creating an MR of your own.

personally i'm no expert on this and it's not a priority for me.
my comment above was mostly that i don't like how i cannot tell which of this code is autogenerated and what was manually adjusted, so i suggested to put those into separate commits.
Stefan as author of the previous older MR also had some good questions that remained unanswered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants