Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bordered versions of logos for dark mode #2

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Add bordered versions of logos for dark mode #2

merged 1 commit into from
Dec 8, 2020

Conversation

charlespierce
Copy link
Collaborator

Info

  • GitHub added "Dark Mode" recently, and the Volta logo in our Readme looks very bad in that mode, since the text is black.

Changes

  • Added new versions of the wordmark and v logos that include a white border

@charlespierce charlespierce mentioned this pull request Dec 8, 2020
Merged
dherman
dherman approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! :shipit:

It feels like ideally we'd have all-white text for dark mode and all-dark text for light mode, but I don't know if GH-flavored markdown makes it possible to alternate like that based on a CSS variable or media query or whatever.

@charlespierce charlespierce merged commit 7c2860e into volta-cli:main Dec 8, 2020
@charlespierce charlespierce deleted the add_bordered branch December 8, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlespierce @dherman