Fix denominator computation in KDense
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix computation of `grid_span`. * Use `denominator=nothing` as kwarg default to choose a reasonable denominator if `grid_lims` are chosen other than `(-1, 1)`. Note: this will modify the behavior for `normalizer ∈ (sigmoid, sigmoid_fast)`, changing denominator from `2/(grid_len-1)` to `1/(grid_len-1)`.
|
just saw this, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid_span.denominator=nothingas kwarg default to choose a reasonable denominator ifgrid_limsare chosen other than(-1, 1). Note: this will modify the behavior fornormalizer ∈ (sigmoid, sigmoid_fast)andgrid_lims=nothing, changing denominator from2/(grid_len-1)to1/(grid_len-1).Hit this when trying to work with custom
grid_lims, which without this change requires passing a handcrafteddenominatorto work properly.