Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert input document to JSDoc format #698

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

KisaragiEffective
Copy link
Contributor

No description provided.

@Natsumi-sama
Copy link
Member

Screenshot 2023-12-03 005005

@KisaragiEffective
Copy link
Contributor Author

@Natsumi-sama I have addressed them in b76bdc1, I did not think it was used in entire code-base 😓

@Natsumi-sama
Copy link
Member

Hah yea it's a bit hard to tell with how insanely large this file is, thanks for this though.

@KisaragiEffective
Copy link
Contributor Author

Could you approve workflows so we can see if they will be green?

@Natsumi-sama
Copy link
Member

It'll be fine it's only comments after all, the real test would be to run eslint --ext .js src/ && prettier --write src/

@KisaragiEffective
Copy link
Contributor Author

It seems that prettier does not like my asterisk positions, but it has fixed them.

@Natsumi-sama Natsumi-sama merged commit 75416ab into vrcx-team:master Dec 4, 2023
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this pull request Dec 4, 2023
* refactor: convert input document to JSDoc format

* refactor: migrate rest of document

* chore: eslint and prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants