-
Notifications
You must be signed in to change notification settings - Fork 349
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
T5559: Add selective proxy ARP and NDP feature
Ability to set proxy ARP/NDP only for specific hosts set protocols static proxy-arp 192.0.2.1 interface eth0 set protocols static proxy-arp 192.0.2.1 interface eth1 set protocols static proxy-ndp 2001:db8::1 interface eth1
- Loading branch information
1 parent
0ad6d33
commit d698d18
Showing
2 changed files
with
166 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
<?xml version="1.0"?> | ||
<interfaceDefinition> | ||
<node name="protocols"> | ||
<children> | ||
<node name="static"> | ||
<children> | ||
<tagNode name="proxy-arp" owner="${vyos_conf_scripts_dir}/protocols_static_proxy.py"> | ||
<properties> | ||
<help>IP address for selective ARP proxy</help> | ||
<valueHelp> | ||
<format>ipv4</format> | ||
<description>IPv4 destination address allowed for proxy-arp</description> | ||
</valueHelp> | ||
<constraint> | ||
<validator name="ipv4-address"/> | ||
</constraint> | ||
</properties> | ||
<children> | ||
<leafNode name="interface"> | ||
<properties> | ||
<help>Interface</help> | ||
<completionHelp> | ||
<script>${vyos_completion_dir}/list_interfaces</script> | ||
</completionHelp> | ||
<valueHelp> | ||
<format>txt</format> | ||
<description>Interface name</description> | ||
</valueHelp> | ||
<constraint> | ||
#include <include/constraint/interface-name.xml.i> | ||
</constraint> | ||
<multi/> | ||
</properties> | ||
</leafNode> | ||
</children> | ||
</tagNode> | ||
<tagNode name="proxy-ndp" owner="${vyos_conf_scripts_dir}/protocols_static_proxy.py"> | ||
<properties> | ||
<help>IPv6 address for selective NDP proxy</help> | ||
<valueHelp> | ||
<format>ipv6</format> | ||
<description>IPv6 destination address</description> | ||
</valueHelp> | ||
<constraint> | ||
<validator name="ipv6-address"/> | ||
</constraint> | ||
</properties> | ||
<children> | ||
<leafNode name="interface"> | ||
<properties> | ||
<help>Interface</help> | ||
<completionHelp> | ||
<script>${vyos_completion_dir}/list_interfaces</script> | ||
</completionHelp> | ||
<valueHelp> | ||
<format>txt</format> | ||
<description>Interface name</description> | ||
</valueHelp> | ||
<constraint> | ||
#include <include/constraint/interface-name.xml.i> | ||
</constraint> | ||
<multi/> | ||
</properties> | ||
</leafNode> | ||
</children> | ||
</tagNode> | ||
</children> | ||
</node> | ||
</children> | ||
</node> | ||
</interfaceDefinition> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
#!/usr/bin/env python3 | ||
# | ||
# Copyright (C) 2023 VyOS maintainers and contributors | ||
# | ||
# This program is free software; you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License version 2 or later as | ||
# published by the Free Software Foundation. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
import os | ||
|
||
from sys import exit | ||
|
||
from vyos.config import Config | ||
from vyos.configdict import node_changed | ||
from vyos.utils.process import call | ||
from vyos import ConfigError | ||
from vyos import airbag | ||
|
||
airbag.enable() | ||
|
||
|
||
def get_config(config=None): | ||
if config: | ||
conf = config | ||
else: | ||
conf = Config() | ||
|
||
base = ['protocols', 'static'] | ||
config = conf.get_config_dict(base, get_first_key=True) | ||
|
||
# Get required keys | ||
keys_to_keep = ['proxy-arp', 'proxy-ndp'] | ||
config = {key: config[key] for key in keys_to_keep if key in config} | ||
|
||
return config | ||
|
||
|
||
def verify(config): | ||
|
||
if 'proxy-arp' in config: | ||
for neighbor, neighbor_conf in config['proxy-arp'].items(): | ||
if 'interface' not in neighbor_conf: | ||
raise ConfigError(f'proxy-arp {neighbor} interface required but not set.') | ||
|
||
if 'proxy-ndp' in config: | ||
for neighbor, neighbor_conf in config['proxy-ndp'].items(): | ||
if 'interface' not in neighbor_conf: | ||
raise ConfigError(f'proxy-ndp {neighbor} interface required but not set.') | ||
|
||
|
||
def generate(config): | ||
pass | ||
|
||
|
||
def apply(config): | ||
if not config: | ||
# Cleanup proxy | ||
call('ip neighbor flush proxy') | ||
call('ip -6 neighbor flush proxy') | ||
return None | ||
|
||
# Add proxy ARP | ||
if 'proxy-arp' in config: | ||
# Cleanup entries before config | ||
call('ip neighbor flush proxy') | ||
for neighbor, neighbor_conf in config['proxy-arp'].items(): | ||
for interface in neighbor_conf.get('interface'): | ||
call(f'ip neighbor add proxy {neighbor} dev {interface}') | ||
|
||
# Add proxy NDP | ||
if 'proxy-ndp' in config: | ||
# Cleanup entries before config | ||
call('ip -6 neighbor flush proxy') | ||
for neighbor, neighbor_conf in config['proxy-ndp'].items(): | ||
for interface in neighbor_conf['interface']: | ||
call(f'ip -6 neighbor add proxy {neighbor} dev {interface}') | ||
|
||
|
||
if __name__ == '__main__': | ||
try: | ||
c = get_config() | ||
verify(c) | ||
generate(c) | ||
apply(c) | ||
except ConfigError as e: | ||
print(e) | ||
exit(1) |