Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5716: Fix smoketest for accel-ppp limiter tbf #2451

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

sever-sever
Copy link
Member

Change Summary

Limiter in the commit cf92295 was changed to tbf Fix smoketest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Fix smoketest

Related Task(s)

Related PR(s)

Component(s) name

smoketest

Proposed changes

How to test

Smoketest result

vyos@r4:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_pppoe-server.py
test_accel_local_authentication (__main__.TestServicePPPoEServer.test_accel_local_authentication) ... ok
test_accel_name_servers (__main__.TestServicePPPoEServer.test_accel_name_servers) ... ok
test_accel_radius_authentication (__main__.TestServicePPPoEServer.test_accel_radius_authentication) ... ok
test_pppoe_server_authentication_protocols (__main__.TestServicePPPoEServer.test_pppoe_server_authentication_protocols) ... ok
test_pppoe_server_client_ip_pool (__main__.TestServicePPPoEServer.test_pppoe_server_client_ip_pool) ... ok
test_pppoe_server_client_ip_pool_name (__main__.TestServicePPPoEServer.test_pppoe_server_client_ip_pool_name) ... ok
test_pppoe_server_client_ipv6_pool (__main__.TestServicePPPoEServer.test_pppoe_server_client_ipv6_pool) ... ok
test_pppoe_server_ppp_options (__main__.TestServicePPPoEServer.test_pppoe_server_ppp_options) ... ok
test_pppoe_server_vlan (__main__.TestServicePPPoEServer.test_pppoe_server_vlan) ... ok

----------------------------------------------------------------------
Ran 9 tests in 44.329s

OK
vyos@r4:~$ 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Limiter in the commit cf92295 was changed to `tbf`
Fix smoketest
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team November 7, 2023 08:13
@sever-sever sever-sever merged commit b7ff6f8 into vyos:current Nov 7, 2023
7 checks passed
@sever-sever
Copy link
Member Author

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Nov 7, 2023

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Nov 7, 2023
T5716: Fix smoketest for accel-ppp limiter tbf (backport #2451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant