Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5713: Strip string after "secret" in IPSEC configs (backport #2437) #2455

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2023

This is an automatic backport of pull request #2437 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

RageLtMan and others added 2 commits November 7, 2023 16:40
Make "strip-private" strip the string after "secret"

(cherry picked from commit 30eb308)
Commit 30eb308 ("T5713: Strip string after "secret" in IPSEC config") had
good intention but this will happen:

use-secret foo CLI node will become " secret xxxxxx" so the output of
strip-private invalidates the configuration.

This has been changed to an exact match of "secret" only

(cherry picked from commit 863af11)
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team November 7, 2023 16:40
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Nov 7, 2023
@c-po c-po merged commit 269ad33 into sagitta Nov 7, 2023
4 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-2437 branch November 7, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

2 participants