utils: T6975: Add 'vrf' and 'netns' arguments to functions in 'vyos.utils.process' #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natali-rs1985
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
c-po,
fett0,
nicolas-fort and
zdc
as code owners
|
👍 |
dmbaturin
requested changes
Dec 23, 2024
There was a problem hiding this comment.
I left a minor suggestion.
Another question is that executing commands in VRFs and network namespace is only available with sudo at the moment. For now, we should probably add an effective UID check (there's a function for that in utils) and raise a "permission denied" error if it's not 0 (root), rather than expose users to odd error messages.
natali-rs1985
force-pushed
the
T6975
branch
2 times, most recently
from
aeee766 to
95f230f
Compare
c-po
reviewed
Dec 24, 2024
| wrapper = f'ip vrf exec {vrf} ' | ||
| elif netns: | ||
| wrapper = f'ip netns exec {netns} ' | ||
| if auth: |
There was a problem hiding this comment.
What does auth do? Where do we use it?
There was a problem hiding this comment.
auth was added in this PR to prevent showing username and password in error message
c-po
requested changes
Dec 31, 2024
dmbaturin
requested changes
Jan 6, 2025
python/vyos/utils/process.py
Outdated
| # Must be run as root to execute command in VRF or network namespace | ||
| if vrf or netns: | ||
| if os.getuid() != 0: | ||
| raise OSError('Permission denied') |
There was a problem hiding this comment.
Suggested change
| raise OSError('Permission denied') | |
| raise OSError('Permission denied: cannot execute commands in VRF and netns contexts as an unprivileged user') |
Maybe make the error more specific?
|
CI integration ❌ failed! Details
|
dmbaturin
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
vyos.utils
Proposed changes
How to test
Smoketest result
Checklist: