-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify img mappings #451
clarify img mappings #451
Conversation
closes #439 This PR provides more detailed conditions for when an `img` element is mapped to the `img` role. This was originally brought up to address what should happen when an `img` lacks or has been given an `src` attribute set to the empty string, as HTML defines such instances as "representing nothing". However, in trying to just add in that condition, it made me realize the mappings were lacking additional nuance to how the element is exposed re: the existence of alternative naming mechanisms besides just `alt`.
Added updates to this PR to indicate that |
@cookiecrook would apprecaite your thoughts on this clarification / if I should just create a wpt test for this to help move it along? |
It couldn't hurt. Well I guess it could hurt, if your expectations are wrong, and the resolving engineer doesn't question it. I would start with a new test file of subtests that include all these variants. If the engines agree on the output, or you are certain it's right check them in. If you aren't sure in the case of one or more subtests, leave it commented or otherwise not running, and file an issue, referencing the issue in the comment. I did something similar recently with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending that one empty vs. valid comment from James :)
Closing, this PR has been migrated to the ARIA monorepo: |
closes #439
This PR provides more detailed conditions for when an
img
element is mapped to theimg
role.This was originally brought up to address what should happen when an
img
lacks or has been given ansrc
attribute set to the empty string, as HTML defines such instances as "representing nothing". However, in trying to just add in that condition, it made me realize the mappings were lacking additional nuance to how the element is exposed re: the existence of alternative naming mechanisms besides justalt
.I have the following examples to fit these conditions:
Question on what to do with
src=" "
. I'd assume that too should be treated likesrc
andsrc=""
. So maybe this PR also needs to call out src with a whitespace value?Implementation
Preview | Diff