Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clipping, shapes and masking #1649

Merged
merged 18 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions features/clip-path-animatable.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
name: Animatable clipping paths
description: Clipping paths in CSS are animated using transitions and CSS animations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Clipping paths in CSS are animated using transitions and CSS animations.
description: Clipping paths in CSS are animated using CSS transitions and animations.

spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'current' spec:

Suggested change
spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path
spec: https://www.w3.org/TR/css-masking/#the-clip-path

I would update the other spec links to match.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer this until resolution of #1785

group: clipping-shapes-masking
compat_features:
- css.properties.clip-path.is_animatable
13 changes: 13 additions & 0 deletions features/clip-path-animatable.yml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Generated from: clip-path-animatable.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: false
support:
chrome: "55"
chrome_android: "55"
edge: "79"
firefox: "49"
firefox_android: "49"
compat_features:
- css.properties.clip-path.is_animatable
8 changes: 8 additions & 0 deletions features/clip-path-boxes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: Clip path boxes
description: The `fill-box`, `stroke-box`, and `view-box` values for the `clip-path` set the part of the shape that will be used to clip the element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `fill-box`, `stroke-box`, and `view-box` values for the `clip-path` set the part of the shape that will be used to clip the element.
description: The `fill-box`, `stroke-box`, and `view-box` values for `clip-path` set an edge of the elements box to use as the clipping shape.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an apostrophe in element's but wanted to verify that was the intent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intent was possessive, but I'm dyslexic. The element has a box. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to confirm it wasn't like attorneys general or something 😆

spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path
group: clipping-shapes-masking
compat_features:
- css.properties.clip-path.fill-box
- css.properties.clip-path.stroke-box
- css.properties.clip-path.view-box
39 changes: 39 additions & 0 deletions features/clip-path-boxes.yml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Generated from: clip-path-boxes.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: low
baseline_low_date: 2023-11-02
support:
chrome: "119"
chrome_android: "119"
edge: "119"
firefox: ≤72
firefox_android: "79"
safari: "13.1"
safari_ios: "13.4"
compat_features:
# baseline: low
# baseline_low_date: 2023-11-02
# support:
# chrome: "119"
# chrome_android: "119"
# edge: "119"
# firefox: "51"
# firefox_android: "51"
# safari: "13.1"
# safari_ios: "13.4"
- css.properties.clip-path.fill-box
- css.properties.clip-path.stroke-box

# baseline: low
# baseline_low_date: 2023-11-02
# support:
# chrome: "119"
# chrome_android: "119"
# edge: "119"
# firefox: ≤72
# firefox_android: "79"
# safari: ≤13.1
# safari_ios: ≤13.4
- css.properties.clip-path.view-box
19 changes: 19 additions & 0 deletions features/clip-path.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: clip-path
description: The `clip-path` CSS property and SVG attribute sets an area of an element that should be displayed. Everything outside the area will be hidden.
jamesnw marked this conversation as resolved.
Show resolved Hide resolved
spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path
# caniuse groups more clip-path features and tells a spottier support story.
# caniuse: css-clip-path
group: clipping-shapes-masking
compat_features:
- css.properties.clip-path
- css.properties.clip-path.basic_shape
- css.properties.clip-path.html_elements
- css.properties.clip-path.path
- css.properties.clip-path.svg_elements
- svg.global_attributes.clip-path
- api.SVGClipPathElement
- api.SVGClipPathElement.clipPathUnits
- api.SVGClipPathElement.transform
- svg.elements.clipPath
- svg.elements.clipPath.clipPathUnits
- svg.elements.clipPath.systemLanguage
124 changes: 124 additions & 0 deletions features/clip-path.yml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
# Generated from: clip-path.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: high
baseline_low_date: 2021-01-21
baseline_high_date: 2023-07-21
support:
chrome: "88"
chrome_android: "88"
edge: "88"
firefox: "71"
firefox_android: "79"
safari: "13.1"
safari_ios: "13"
compat_features:
# baseline: high
# baseline_low_date: 2015-07-29
# baseline_high_date: 2018-01-29
# support:
# chrome: "1"
# chrome_android: "18"
# edge: "12"
# firefox: "1.5"
# firefox_android: "4"
# safari: "3"
# safari_ios: "1"
- api.SVGClipPathElement
- api.SVGClipPathElement.clipPathUnits
- api.SVGClipPathElement.transform

# baseline: high
# baseline_low_date: 2015-07-29
# baseline_high_date: 2018-01-29
# support:
# chrome: "1"
# chrome_android: "18"
# edge: "12"
# firefox: "1.5"
# firefox_android: "4"
# safari: "3"
# safari_ios: "3"
- svg.elements.clipPath
- svg.elements.clipPath.clipPathUnits

# baseline: high
# baseline_low_date: 2015-07-29
# baseline_high_date: 2018-01-29
# support:
# chrome: "1"
# chrome_android: "18"
# edge: "12"
# firefox: "12"
# firefox_android: "14"
# safari: "3"
# safari_ios: "3"
- svg.elements.clipPath.systemLanguage

# baseline: high
# baseline_low_date: 2017-03-07
# baseline_high_date: 2019-09-07
# support:
# chrome: "23"
# chrome_android: "25"
# edge: "12"
# firefox: "52"
# firefox_android: "52"
# safari: "7"
# safari_ios: "7"
- svg.global_attributes.clip-path

# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "55"
# chrome_android: "55"
# edge: "79"
# firefox: "3.5"
# firefox_android: "4"
# safari: "9.1"
# safari_ios: "9.3"
- css.properties.clip-path
- css.properties.clip-path.html_elements

# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "55"
# chrome_android: "55"
# edge: "79"
# firefox: "52"
# firefox_android: "52"
# safari: "9.1"
# safari_ios: "9.3"
- css.properties.clip-path.svg_elements

# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "55"
# chrome_android: "55"
# edge: "79"
# firefox: "54"
# firefox_android: "54"
# safari: "9.1"
# safari_ios: "9.3"
- css.properties.clip-path.basic_shape

# ⬇️ Same status as overall feature ⬇️
# baseline: high
# baseline_low_date: 2021-01-21
# baseline_high_date: 2023-07-21
# support:
# chrome: "88"
# chrome_android: "88"
# edge: "88"
# firefox: "71"
# firefox_android: "79"
# safari: "13.1"
# safari_ios: "13"
- css.properties.clip-path.path
1 change: 1 addition & 0 deletions features/masks.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: Masks
description: The `mask` CSS property (and several longhand properties) partially or completely hides an element according to the shape and depth of an image.
spec: https://drafts.fxtf.org/css-masking-1/#positioned-masks
group: clipping-shapes-masking
caniuse: css-masks
9 changes: 9 additions & 0 deletions features/path-shape.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: "`path()` shape"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this feature in a separate PR (from synchronous discussion)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To elaborate here: the BCD data is very messy. It has subfeatures to describe support in d, shape-outside, and offset-path, but also represents that information as partial support on path. It ought to do one or the other. We'll need to fix this in BCD.

(Please @ me on that PR, when you open it.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to #1799

description: The `path()` CSS shape function creates an shapes for use with `clip-path`, `shape-outside`, and the `d` property on an SVG.
spec: https://drafts.csswg.org/css-shapes-1/#supported-basic-shapes
group: clipping-shapes-masking
compat_features:
- css.types.basic-shape.path
- css.types.basic-shape.path.clip-path
- css.types.basic-shape.path.d
- css.types.basic-shape.path.shape-outside
11 changes: 11 additions & 0 deletions features/path-shape.yml.dist
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit of a surprising result- these features do have some implementation, and I'm not sure if I'm misreading the BCD data, or if there is a bug in generating this.

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Generated from: path-shape.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: false
support: {}
compat_features:
- css.types.basic-shape.path
- css.types.basic-shape.path.clip-path
- css.types.basic-shape.path.d
- css.types.basic-shape.path.shape-outside
17 changes: 17 additions & 0 deletions features/shape-outside.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: shape-outside
description: The `shape-outside` CSS property, along with `shape-margin` and `shape-image-threshold`, sets the shape around which adjacent content will wrap.
spec: https://drafts.csswg.org/css-shapes-1/#declaring-shapes
group: clipping-shapes-masking
status:
compute_from: css.properties.shape-outside
compat_features:
- css.properties.shape-image-threshold
- css.properties.shape-margin
- css.properties.shape-outside
- css.properties.shape-outside.none
- css.properties.shape-outside.circle
- css.properties.shape-outside.gradient
- css.properties.shape-outside.image
- css.properties.shape-outside.inset
- css.properties.shape-outside.path
- css.properties.shape-outside.polygon
41 changes: 41 additions & 0 deletions features/shape-outside.yml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Generated from: shape-outside.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: high
baseline_low_date: 2020-01-15
baseline_high_date: 2022-07-15
support:
chrome: "37"
chrome_android: "37"
edge: "79"
firefox: "62"
firefox_android: "62"
safari: "10.1"
safari_ios: "10.3"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "37"
# chrome_android: "37"
# edge: "79"
# firefox: "62"
# firefox_android: "62"
# safari: "10.1"
# safari_ios: "10.3"
- css.properties.shape-image-threshold
- css.properties.shape-margin
- css.properties.shape-outside
- css.properties.shape-outside.circle
- css.properties.shape-outside.gradient
- css.properties.shape-outside.image
- css.properties.shape-outside.inset
- css.properties.shape-outside.none
- css.properties.shape-outside.polygon

# baseline: false
# support: {}
- css.properties.shape-outside.path
16 changes: 16 additions & 0 deletions features/shapes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: shapes
description: The `circle()`, `ellipse()`, `inset()`, `polygon()`, `rect()`, and `xywh()` CSS shape functions create shapes for use with `clip-path` and `shape-outside`.
spec: https://drafts.csswg.org/css-shapes-1/#basic-shape-functions
caniuse: css-shapes
group: clipping-shapes-masking
status:
compute_from: css.types.basic-shape
compat_features:
- css.types.basic-shape
- css.types.basic-shape.animation
- css.types.basic-shape.circle
- css.types.basic-shape.ellipse
- css.types.basic-shape.inset
- css.types.basic-shape.polygon
- css.types.basic-shape.rect
- css.types.basic-shape.xywh
43 changes: 43 additions & 0 deletions features/shapes.yml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Generated from: shapes.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: high
baseline_low_date: 2020-01-15
baseline_high_date: 2022-07-15
support:
chrome: "37"
chrome_android: "37"
edge: "79"
firefox: "54"
firefox_android: "54"
safari: "10.1"
safari_ios: "10.3"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "37"
# chrome_android: "37"
# edge: "79"
# firefox: "54"
# firefox_android: "54"
# safari: "10.1"
# safari_ios: "10.3"
- css.types.basic-shape
- css.types.basic-shape.animation
- css.types.basic-shape.circle
- css.types.basic-shape.ellipse
- css.types.basic-shape.inset
- css.types.basic-shape.polygon

# baseline: false
# support:
# firefox: "122"
# firefox_android: "122"
# safari: "17.2"
# safari_ios: "17.2"
- css.types.basic-shape.rect
- css.types.basic-shape.xywh
2 changes: 2 additions & 0 deletions groups/clipping-shapes-masking.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
name: Clipping, shapes and masking
parent: css
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The potential issue with this group is that it now contains features that apply to both CSS and SVG.
Your features make sense to me, and I'm fine with making them apply to both languages, if others are. But in that case, we need to make this group belong to both CSS and SVG (which is not possible today).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point- I've been thinking we will need to address the overlap between CSS and SVG more thoroughly at some point. Allowing for multiple parents for a group would be complex, so I'll remove the parent group here for now.