Implement filtering on companies and company interests #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ivarnakken
changed the title
ivarnakken
changed the title
ivarnakken
force-pushed
the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
from
65fff33 to
9310dac
Compare
norbye
requested changes
Dec 15, 2024
4 tasks
ivarnakken
force-pushed
the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
2 times, most recently
from
108136e to
d7e21e8
Compare
ivarnakken
added
do-not-merge/WIP
ivarnakken
removed
the
do-not-merge/WIP
norbye
requested changes
Dec 18, 2024
ivarnakken
force-pushed
the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
from
6ea9656 to
3944494
Compare
norbye
reviewed
Dec 18, 2024
ivarnakken
force-pushed
the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
from
0ad4474 to
18f0075
Compare
ivarnakken
force-pushed
the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
from
18f0075 to
cb5aef8
Compare
ivarnakken
added
the
do-not-merge/hold
ivarnakken
force-pushed
the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
2 times, most recently
from
2f3a1e8 to
bf571b1
Compare
Search on names and descriptions, and filter out inactive companies.
Choosing the "show all semesters" option would just default to the current semester.
Company interests are now under /bdb/company-interests. This follows the routing patterns seen on other pages, and should therefore be more "clear"
Didn't seem to work on mobile, and I think it's clean to use it on all viewports.
Same page component and tabs
ivarnakken
force-pushed
the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
from
bf571b1 to
95b16b9
Compare
ivarnakken
removed
the
do-not-merge/hold
ivarnakken
deleted the
ivarnakken/aba-1203-implement-filtering-on-companies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Search on names and descriptions, and filter out inactive companies.
Will add company type filtering as well; but this is blocked by webkom/lego#3702
Result
Search filtering has also been implemented for company interest! Very useful instead of having to go through all semesters manually ..
Testing
Tested that the search filtering works fine. There's some issues with the active / inactive checkbox ... it seems all inactive companies are still not retrieved by the selector?
Resolves ABA-1203
Resolves ABA-1205
Resolves ABA-1209