Revert crypt hash generation on login #3720
Open
+1
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
approved these changes
Jan 24, 2025
Not really, just wanted to make sure it wasn't eventually forgotten. And I assumed that there wouldn't be that many users that haven't logged in during the last semester that will login this semester, and if I delay this until august I won't be here to remember it 🤷 |
norbye
force-pushed
the
revert-crypt-generation
branch
from
93392c5 to
13cd44a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3720 +/- ##
==========================================
- Coverage 89.67% 89.66% -0.01%
==========================================
Files 703 703
Lines 22534 22524 -10
==========================================
- Hits 20207 20197 -10
Misses 2327 2327 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been generating crypt hashes on login for users missing it due to it not being set on registration until 8 months ago. Now we're down from 487 users with no hash to 78, so I figured it could be time to remove the temporary update.
If any of the remaining 78 users against all odds require the hash they can reset their password.
Originally implemented in #3602 and #3603
Resolves ABA-942