Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unset variables when create or rename data variables #4808

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Jan 30, 2025

Ref #4768

Now user can write expressions with not existing variables and create these variables later. Builder will automatically traverse all expressions and bind to newly created variable by name.

Additionally user will see suggestions with all unset variables in subtree.

Screenshot 2025-01-30 at 12 35 21

Ref #4768

Now user can write expressions with not existing variables
and create these variables later. They will automatically
traverse all expressions and bind to newly created variable
by name.

Additionally user will see suggestions with all unset variables
in subtree.
@TrySound TrySound requested review from kof and johnsicili January 30, 2025 05:41
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING.

@TrySound
Copy link
Member Author

image

@johnsicili
Copy link
Contributor

"pick a not defined" doesn't sound good but used yours as inspo:

Enter a variable name, or select from the dropdown if any variables have been used in expressions but not yet created.

@johnsicili
Copy link
Contributor

Didn't see that it's conditional now. Maybe: Enter a new variable or select a variable that has been used in expressions but not yet created.

@TrySound TrySound merged commit 53ace3b into main Jan 31, 2025
15 checks passed
@TrySound TrySound deleted the unset-variable branch January 31, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants