-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the --current-size and --exit-zero to optionally show current docker image size and avoid stop the CI even if exceed max_size and max-layers #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I proposed several better names :)
3e8f93c
to
b76c142
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 33 58 +25
Branches 1 5 +4
=========================================
+ Hits 33 58 +25 ☔ View full report in Codecov by Sentry. |
@sobolevn done. Docker is failing because it tries to install version 2.1.0, however it has not been released yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
d29654f
to
6bd3c19
Compare
Dockerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sobolevn The message at the beginning of this Dockerfile is not true, because the latest version of disl
on docker hub is 3 years old.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore this check for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove poetry check
for now and add 3.13
as the test target.
Done in 806ab04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Small nitpicks and it will be ready to be merged!
and allow execute it as module via python -m docker_image_size_limit
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
--current-size
to display the current size of the docker image. Maybe partially fix Running without a size parameter should only display current size #224--exit-zero
to Exit with 0 even if docker image size/layers exceedmax_size
andmax-layers
__main__.py
entrypoint to be able execute via module, that itpython -m docker_image_size_limit
files
argument instead offile
argument in thecodecov
github action since it deprecate thefile
argument in favor offiles
2.1.0
It Maybe introduce a breaking change since the
_check_image
function now return 3 values instead of 2