Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: cleanup "create an element" #1331

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 12, 2024

@annevk annevk requested a review from domfarolino December 12, 2024 12:57
annevk added a commit to whatwg/html that referenced this pull request Dec 12, 2024
While here we also teach the remaining "enqueue a custom element callback reaction" callers about lists.

Corresponding DOM PR: whatwg/dom#1331.
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this PR should accompany one that updates the relevant HTML reference too: https://html.spec.whatwg.org/C#creating-and-inserting-nodes:create-an-element?

dom.bs Show resolved Hide resolved
<p>If the <var>synchronous custom elements flag</var> is set, then run this step while
catching any exceptions:
<p>If <var>synchronousCustomElements</var> is true, then run this step while catching any
exceptions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not for this PR, but I guess we should not say anything here about exceptions, and just link to https://webidl.spec.whatwg.org/#an-exception-was-thrown somewhere in "If this step threw an exception" below. Doesn't need to happen in this PR I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, that would be nice to adopt.

@domfarolino
Copy link
Member

I guess this PR should accompany one that updates the relevant HTML reference too: https://html.spec.whatwg.org/C#creating-and-inserting-nodes:create-an-element?

Heh whoops: whatwg/html#10857.

@annevk annevk merged commit 7801c9d into main Dec 12, 2024
2 checks passed
@annevk annevk deleted the annevk/create-an-element branch December 12, 2024 15:38
annevk added a commit to whatwg/html that referenced this pull request Dec 12, 2024
While here we also teach the remaining "enqueue a custom element callback reaction" callers about lists.

Corresponding DOM PR: whatwg/dom#1331.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants