-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: cleanup "create an element" #1331
Conversation
While here we also teach the remaining "enqueue a custom element callback reaction" callers about lists. Corresponding DOM PR: whatwg/dom#1331.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this PR should accompany one that updates the relevant HTML reference too: https://html.spec.whatwg.org/C#creating-and-inserting-nodes:create-an-element?
<p>If the <var>synchronous custom elements flag</var> is set, then run this step while | ||
catching any exceptions: | ||
<p>If <var>synchronousCustomElements</var> is true, then run this step while catching any | ||
exceptions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not for this PR, but I guess we should not say anything here about exceptions, and just link to https://webidl.spec.whatwg.org/#an-exception-was-thrown somewhere in "If this step threw an exception" below. Doesn't need to happen in this PR I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, that would be nice to adopt.
Heh whoops: whatwg/html#10857. |
While here we also teach the remaining "enqueue a custom element callback reaction" callers about lists. Corresponding DOM PR: whatwg/dom#1331.
Preview | Diff