Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.7 make barcode improvement #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anyonetff
Copy link

MakeBarcode easy to use as Java API

  1. Rewrite process to fix some default value problem
  2. Add processToStream to create OutputStream
  3. Add processToByte to create byte[]
  4. Add setters to Settings, add whiteSpace Support
  5. Add SymbolType, SymbolFormat
  6. Add WhiteSpace Support, Add BarHeight Support

Problem found:

  1. the EAN-8, EAN13, data length validator is not smart
  2. the EANX offsetX is not correct. the digits is out of canvas.

MakeBarcode easy to use as Java API
1. Rewrite process to fix some default value problem
2. Add processToStream to create OutputStream
3. Add processToByte to create byte[]
4. Add setters to Settings, add whiteSpace Support
5. Add SymbolType, SymbolFormat
6. Add WhiteSpace Support, Add BarHeight Support

problem found:
1. the EAN-8, EAN13, data length validator is not smart
MakeBarcode easy to use as Java API
1. Rewrite process to fix some default value problem
2. Add processToStream to create OutputStream
3. Add processToByte to create byte[]
4. Add setters to Settings, add whiteSpace Support
5. Add SymbolType, SymbolFormat
6. Add WhiteSpace Support, Add BarHeight Support

problem found:
1. the EAN-8, EAN13, data length validator is not smart
@gredler
Copy link
Collaborator

gredler commented Oct 7, 2024

Thank you for the contribution. Unfortunately there are too many changes mixed in this single PR to easily review. It would be best to submit smaller individual PRs for specific, focused improvements. For example, if you'd like to enable the -w command line option, a PR that does only that would be welcome. Also please try to avoid unnecessary formatting changes, and keep comments in English. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants