Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woo 2.0 Brand Updates #13254

Merged
merged 189 commits into from
Jan 30, 2025
Merged

Woo 2.0 Brand Updates #13254

merged 189 commits into from
Jan 30, 2025

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 8, 2025

Part of: woocommerce/woomobile-private#373

Description

This PR merges the main feature branch of the Brand Updates project (pffQ75-10m-p2) into trunk. It updates the color theme, logo, and illustrations.

This PR only includes merge commits from other project PRs, syncing with trunk commits, and a commit for updating RELEASE-NOTES.

Steps to reproduce

All changes have already been tested in individual PRs. For this PR, a general test should ve sufficient. You can follow the test plan (pe5sF9-3vc-p2). Items labeled "Extra cases:" are optional to test.

Testing information

Please test both the light and dark modes.

The tests that have been performed

All the commits here have already been tested in other PRs.
Cases in the test plan.

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

Removed purple colors were already Woo Purple colors in color-studio.blog. There's no need to keep purple and WooPurple.
These images are not necessary.
These are removed because they're the same for all build variants.
Our minSdk is 36 now, so we don't need -c26 suffix anymore.
Removed purple colors were already Woo Purple colors in color-studio.blog. There's no need to keep purple and WooPurple.
@irfano irfano requested a review from JorgeMucientes January 29, 2025 09:47
@irfano irfano added this to the 21.6 milestone Jan 29, 2025
@irfano irfano marked this pull request as ready for review January 29, 2025 09:47
@JorgeMucientes JorgeMucientes self-assigned this Jan 30, 2025
The scale values for `ic_launcher_foreground.xml` have been updated from 0.7213954 to 0.61.
@JorgeMucientes
Copy link
Contributor

Awesome job in this whole project @irfano :kudos 🙌🏼

I smoke-tested the app's main flows as well as some optional ones. I found a few minor things that might be worth checking because I'm not sure if their are bugs or the color usage is intentional. In any case, none are blocking imho:

Filters with old pink.

Close Account pink color

Badge pink color

@irfano
Copy link
Contributor Author

irfano commented Jan 30, 2025

Thanks for reviewing, @JorgeMucientes! These pink colors haven't changed, and they use the latest pink tones from Color Studio.

@irfano irfano merged commit 975c78d into trunk Jan 30, 2025
15 checks passed
@irfano irfano deleted the feature/woo-2.0-brand-updates branch January 30, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants