Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Order Creation] Track orders with customers that are registered or not #13406

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 27, 2025

Closes: #13405

Description

The PR adds a propertyis_customer_registered to ORDER_CREATION_CUSTOMER_ADDED event
The goal is to eventually have some data on what type of customers our merchants add in the mobile app

Steps to reproduce

  • Order -> Order creation
  • Add a customer registered and not
  • Noticed tracking in the logcat:
Tracked: woocommerceandroid_order_creation_customer_added, Properties: {"is_customer_registered":"false","blog_id":198349371,"is_wpcom_store":true,"was_ecommerce_trial":false,"plan_product_slug":"business-bundle","store_id":"534e18db-8439-411e-9dfc-467cf73a450f","is_debug":true,"site_url":"https:\/\/paymentwithoutaddress.wpcomstaging.com","cached_woo_core_version":"9.6.0"}
Tracked: woocommerceandroid_order_creation_customer_added, Properties: {"is_customer_registered":"true","blog_id":198349371,"is_wpcom_store":true,"was_ecommerce_trial":false,"plan_product_slug":"business-bundle","store_id":"534e18db-8439-411e-9dfc-467cf73a450f","is_debug":true,"site_url":"https:\/\/paymentwithoutaddress.wpcomstaging.com","cached_woo_core_version":"9.6.0"}

The tests that have been performed

Above

Images/gif

No visual changes

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added category: tracks Related to analytics, including Tracks Events. feature: order creation Related to the Order Creation feature labels Jan 27, 2025
@kidinov kidinov added this to the 21.6 milestone Jan 27, 2025
@kidinov kidinov requested a review from AnirudhBhat January 27, 2025 15:01
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit18bbc62
Direct Downloadwoocommerce-wear-prototype-build-pr13406-18bbc62.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit18bbc62
Direct Downloadwoocommerce-prototype-build-pr13406-18bbc62.apk

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.11%. Comparing base (73135c1) to head (18bbc62).
Report is 88 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13406   +/-   ##
=========================================
  Coverage     41.10%   41.11%           
- Complexity     6486     6487    +1     
=========================================
  Files          1325     1325           
  Lines         77572    77574    +2     
  Branches      10694    10695    +1     
=========================================
+ Hits          31889    31891    +2     
  Misses        42850    42850           
  Partials       2833     2833           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnirudhBhat AnirudhBhat self-assigned this Jan 30, 2025
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@AnirudhBhat AnirudhBhat merged commit 57b11e5 into trunk Jan 30, 2025
18 of 22 checks passed
@AnirudhBhat AnirudhBhat deleted the 13405-order-creation-track-orders-with-customers-that-are-registered-or-not branch January 30, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: order creation Related to the Order Creation feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Order creation] Track orders with customers that are registered or not
4 participants