Improve accessibility support in IPP flows #13414
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WooCommerce/src/main/res/layout/card_reader_connect_dialog.xml
Dismissed
Show dismissed
Hide dismissed
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content"> | ||
| android:layout_height="wrap_content" | ||
| android:background="@color/color_surface_elevated" |
Check warning
Code scanning / Android Lint
Overdraw: Painting regions more than once Warning
| android:layout_height="wrap_content" | ||
| android:layout_width="wrap_content" | ||
| android:background="@color/color_surface_elevated" |
Check warning
Code scanning / Android Lint
Overdraw: Painting regions more than once Warning
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:background="@color/color_surface_elevated" |
Check warning
Code scanning / Android Lint
Overdraw: Painting regions more than once Warning
| app:layout_constraintEnd_toEndOf="@id/progressImageView" | ||
| app:layout_constraintStart_toStartOf="@id/progressImageView" | ||
| app:layout_constraintTop_toTopOf="@id/progressImageView" /> | ||
| <ImageView |
Check warning
Code scanning / Android Lint
Image without contentDescription Warning
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| tools:context="com.woocommerce.android.ui.payments.cardreader.connect.CardReaderConnectDialogFragment"> | ||
| android:background="@color/color_surface_elevated" |
Check warning
Code scanning / Android Lint
Overdraw: Painting regions more than once Warning
samiuelson
added
category: accessibility
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13414 +/- ##
============================================
- Coverage 37.89% 37.87% -0.02%
+ Complexity 8957 8956 -1
============================================
Files 2050 2050
Lines 112105 112092 -13
Branches 14173 14173
============================================
- Hits 42477 42460 -17
- Misses 65749 65753 +4
Partials 3879 3879 ☔ View full report in Codecov by Sentry. |
Closes: #13250
Description
The goal of this PR is to fix the UI of the card reader connection and payment flows in case font size is increased in the accessibility settings of the device.
wrap_content, and min height was introduced instead. This way the dialogs keep consistent size in case a standard "text size" is set on the device. The height of the dialogs can now scale, however, in case the font scale is increased.illustrationimage views are now hidden in case the font scale is increased significantly (> 1.5).Steps to reproduce
Testing information
Test the following flows with the increased font size settings:
The easy way to test the accessibility settings is to use "Device UI Shortcuts" > "Font size" from the level of Android Studio:
To change the font scale dynamically.
The tests that have been performed
Images/gif
Screen_recording_20250206_163200.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: