Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update line height for prologue headers #13420

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 30, 2025

Description

This updates the line height of headers on the login prologue screens, as requested from: pffQ75-10m-p2#comment-1027

I set the new line height to 29, which is 1.2 times the text size, as suggested here. I didn't make this change for for all headers since it falls outside the scope of this PR.

Steps to reproduce

Clean install

The tests that have been performed

Screens below

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 30, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitc30a7a7
Direct Downloadwoocommerce-wear-prototype-build-pr13420-c30a7a7.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitc30a7a7
Direct Downloadwoocommerce-prototype-build-pr13420-c30a7a7.apk

@JorgeMucientes JorgeMucientes self-assigned this Jan 30, 2025
Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JorgeMucientes JorgeMucientes merged commit 31671f1 into feature/woo-2.0-brand-updates Jan 30, 2025
18 checks passed
@JorgeMucientes JorgeMucientes deleted the feature/update-login-prologue-headers-size branch January 30, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants