Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app logo size #13422

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 30, 2025

Description

This makes the Woo text smaller in the app icon. This was requested from pffQ75-10m-p2#comment-1027

Steps to reproduce

Just install the app and check the app logo.

The tests that have been performed

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

The scale values for `ic_launcher_foreground.xml` have been updated from 0.7213954 to 0.61.
@irfano irfano requested a review from JorgeMucientes January 30, 2025 14:37
@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 30, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 30, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9c4e4a0
Direct Downloadwoocommerce-wear-prototype-build-pr13422-9c4e4a0.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 30, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9c4e4a0
Direct Downloadwoocommerce-prototype-build-pr13422-9c4e4a0.apk

Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +9 to +10
android:scaleX="0.61"
android:scaleY="0.61">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor np, can we apply this to wasabi variant too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Otherwise, I would have had to open another PR. 😅
Done: 9c4e4a0
image

@irfano irfano merged commit 118e164 into feature/woo-2.0-brand-updates Jan 30, 2025
15 checks passed
@irfano irfano deleted the feature/udpate-app-logo-size branch January 30, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants