Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Order list] Remove order creation survey #13423

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 30, 2025

Closes: #13421

Maybe affects #13259 too, in positive way =)

Description

Removes the survey which is not in use

Testing information

Validate that there is no regression on the order list screen both in 1 and 2 panes modes

The tests that have been performed

Aboce

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added this to the 21.6 milestone Jan 30, 2025
@kidinov kidinov requested a review from samiuelson January 30, 2025 14:56
@kidinov kidinov linked an issue Jan 30, 2025 that may be closed by this pull request
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 30, 2025

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commita907f3a
Direct Downloadwoocommerce-wear-prototype-build-pr13423-a907f3a.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commita907f3a
Direct Downloadwoocommerce-prototype-build-pr13423-a907f3a.apk

@kidinov kidinov added the category: tracks Related to analytics, including Tracks Events. label Jan 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.22%. Comparing base (32dd18c) to head (a907f3a).
Report is 10 commits behind head on trunk.

Files with missing lines Patch % Lines
...merce/android/ui/orders/list/OrderListViewModel.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13423      +/-   ##
============================================
- Coverage     41.23%   41.22%   -0.01%     
+ Complexity     6549     6542       -7     
============================================
  Files          1326     1326              
  Lines         77732    77706      -26     
  Branches      10702    10697       -5     
============================================
- Hits          32051    32033      -18     
+ Misses        42837    42832       -5     
+ Partials       2844     2841       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samiuelson samiuelson merged commit fe7f276 into trunk Jan 30, 2025
18 of 19 checks passed
@samiuelson samiuelson self-assigned this Jan 30, 2025
@samiuelson samiuelson deleted the 13421-order-list-remove-creation-survey branch January 30, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. Tech Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Order List] Remove creation survey
5 participants