[bazel] Update toolchain to support systemcore #7689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to merge this to main? I'd somewhat prefer to keep the systemcore-related changes localized to the 2027 branch. |
|
I think the updates to As for the toolchain update, I could change the base branch to 2027, but for the most part this should be a no-op in the main branch. It adds the option for systemcore, but doesn't actually update CI or add any switch'ing operating system during a build |
PeterJohnson
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the toolchains version to one that supports systemcore, mostly for the 2027 branch. Also bumps a couple of versions that were updated in gradle but not in bazel.
I have tested builds in a more bazl'ified version of the 2027 branch and can make that PR once this gets merged over there.