[bazel] Add macros to build jni code and java tests #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork Sync: Update from parent repository
github-actions
bot
added
component: ntcore
pjreiniger
commented
Jan 16, 2025
| @@ -14,6 +14,7 @@ modifiableFileExclude { | |||
| thirdparty/ | |||
| \.patch$ | |||
| gradlew | |||
| BUILD.bazel | |||
There was a problem hiding this comment.
wpiformat was fighting buildifier when it comes to empty BUILD.bazel files
Gold856
reviewed
Jan 16, 2025
|
|
||
| def wpilib_jni_java_library( | ||
| name, | ||
| native_libs = [], |
There was a problem hiding this comment.
For now. I think it is fine to leave unused and populated in the files that use it
There are a couple other steps you can do to get the jar to automatically bring the jni.so library around with it that I have implemented in my mega-fork, but it requires that the code is built into a shared library which we are kicking down the road.
Fork Sync: Update 2027 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to build the JNI code, and a helper macro to build the code for java tests. This greatly increases the coverage of files built by bazel, and hits pretty much everything but the examples (covered by #7690), and things involving wpigui (that will be the next traunch of stuff after this lands and also gets up and running in the 2027 branch)
The JNI helper is slightly complicated because the policy in wpilib seems to be to include the auto-generated headers in the jni.cpp's. Luckily bazel gives you access to those generated files through a zip file. There are a couple other steps you can do to get the jar to automatically bring the jni.so library around with it that I have implemented in my mega-fork, but it requires that the code is built into a shared library which we are kicking down the road.
In addition, this creates a little helper function to easily build java unit tests. At the moment, because of the lack of shared libraries the tests are tempoarily getting built as a binary instead of a test so that they don't fail. In my mega-fork this macro also handles putting the shared libraries in a special spot so the test can find them, but again that will be a later problem to address.