Add checkstyle check for deprecation #7738
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures java deprecated notation is paired with javadoc and vice versa. Adds javadoc deprecation for MecanumControllerCommand, ArmFeedForward, ElevatorFeedforward, and MecanumDriveMotorVoltages Fixes wpilibsuite#7736 Supersedes wpilibsuite#7737
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
github-actions
bot
added
component: command-based
MecanumControllerCommand isn't implemented in python, so no PR necessary |
Comment on lines
+175
to
+176
| * @deprecated MecanumControllerCommand does not allow for much visibility for troubleshooting. | ||
| * Compose HolonomicDriveController within a subystem. |
There was a problem hiding this comment.
Suggested change
| * @deprecated MecanumControllerCommand does not allow for much visibility for troubleshooting. | |
| * Compose HolonomicDriveController within a subystem. | |
| * @deprecated Use {@link MecanumVoltagesConsumer} instead of {@code Consumer<MecanumDriveMotorVoltages}. |
The deprecation was added in #6760, and the MecanumVoltagesConsumer overloads are not deprecated. We could deprecate those as well for the in the original codereason, but that would be a separate PR.
Comment on lines
+313
to
+314
| * @deprecated MecanumControllerCommand does not allow for much visibility for troubleshooting. | ||
| * Compose HolonomicDriveController within a subystem. |
There was a problem hiding this comment.
Suggested change
| * @deprecated MecanumControllerCommand does not allow for much visibility for troubleshooting. | |
| * Compose HolonomicDriveController within a subystem. | |
| * @deprecated Use {@link MecanumVoltagesConsumer} instead of {@code Consumer<MecanumDriveMotorVoltages>}. |
| /** | ||
| * Represents the motor voltages for a mecanum drive drivetrain. | ||
| * | ||
| * @deprecated use a fuctional interface intead. |
There was a problem hiding this comment.
Suggested change
| * @deprecated use a fuctional interface intead. | |
| * @deprecated Use {@link MecanumControllerCommand.MecanumVoltagesConsumer} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures java deprecated notation is paired with javadoc and vice versa.
Adds javadoc deprecation for MecanumControllerCommand, ArmFeedForward, ElevatorFeedforward, and MecanumDriveMotorVoltages
Fixes #7736
Supersedes #7737