Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predefined flows for push authenticator #7440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add predefined flows for push authenticator #7440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/admin.authentication-flow-builder.v1/components/side-panel-drawer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*/

:root {
--asg-auth-flow-builder-side-panel-drawer-width: 450px;
--asg-auth-flow-builder-side-panel-drawer-width: 480px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a screenshot of the UI with this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-28 at 21 02 17

--asg-auth-flow-builder-side-panel-drawer-mini-width: 32px;
--asg-auth-flow-builder-side-panel-drawer-content-background: #fcfcfc;
--asg-auth-flow-builder-side-panel-toolbar-height: 48px;
Expand Down
1 change: 1 addition & 0 deletions features/admin.authentication-flow-builder.v1/data/flow-sequences/mfa/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@
export { default as EmailOTPSecondFactorLoginSequence } from "./second-factor-email-otp-sequence.json";
export { default as SMSOTPSecondFactorLoginSequence } from "./second-factor-sms-otp-sequence.json";
export { default as TOTPSecondFactorLoginSequence } from "./second-factor-totp-sequence.json";
export { default as PushAuthSecondFactorLoginSequence } from "./second-factor-push-auth-sequence.json";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we made sure that this can be enabled/disabled conditionally in console UI?

22 changes: 22 additions & 0 deletions ...hentication-flow-builder.v1/data/flow-sequences/mfa/second-factor-push-auth-sequence.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"steps": [
{
"id": 1,
"options": [
{
"authenticator": "BasicAuthenticator",
"idp": "LOCAL"
}
]
},
{
"id": 2,
"options": [
{
"authenticator": "push-notification-authenticator",
"idp": "LOCAL"
}
]
}
]
}
1 change: 1 addition & 0 deletions features/admin.authentication-flow-builder.v1/data/flow-sequences/passwordless/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ export { default as EmailOTPPasswordlessLoginSequence } from "./email-otp-sequen
export { default as MagicLinkPasswordlessLoginSequence } from "./magic-link-sequence.json";
export { default as FIDO2PasswordlessLoginSequence } from "./passkey-login-sequence.json";
export { default as SmsOtpPasswordlessLoginSequence } from "./sms-otp-sequence.json";
export { default as PushAuthPasswordlessLoginSequence } from "./push-auth-sequence.json";
13 changes: 13 additions & 0 deletions ...n.authentication-flow-builder.v1/data/flow-sequences/passwordless/push-auth-sequence.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will enable push auth login sequence in visual editor, but may not show it in the classic editor (which is disabled in IS, but still enabled in Asgardeo).

Therefore, we may need to updated the classic editor quickstart as well.

Screenshot 2025-01-29 at 12 10 22

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the feature is still disabled in asgardeo, we can avoid this for now.

"steps": [
{
"id": 1,
"options": [
{
"authenticator": "push-notification-authenticator",
"idp": "LOCAL"
}
]
}
]
}
1 change: 1 addition & 0 deletions features/admin.identity-providers.v1/configs/ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const getAuthenticatorIcons = (): any => {
microsoft: MicrosoftLogo,
office365: Office365Logo,
push: PushIcon,
"push-notification-authenticator": PushIcon,
pavinduLakshan marked this conversation as resolved.
Show resolved Hide resolved
sessionExecutor: ClockColoredIcon,
"sms-otp-authenticator": SMSOTPIcon,
smsOTP: SMSOTPIcon,
Expand Down
Loading