Add Support for Connected Apps in Custom Local Authenticators #7481
+145
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shenali-SJ
requested review from
pavinduLakshan,
ashanthamara and
JayaShakthi97
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7481 +/- ##
=======================================
Coverage 41.98% 41.98%
=======================================
Files 42 42
Lines 936 936
Branches 214 233 +19
=======================================
Hits 393 393
Misses 543 543
Flags with carried forward coverage won't be shown. Click here to find out more. |
| * @param authenticatorId - ID of the local authenticator. | ||
| * @returns A promise containing the response. | ||
| */ | ||
| export const getConnectedAppsOfAuthenticator = (authenticatorId: string): Promise<any> => { |
There was a problem hiding this comment.
Shall we define a custom hook with SWR for this?
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the custom local authenticator UI components to support connected apps.
API to fetch connected apps related to a custom authenticator:
authenticators/custom/<custom-local-authenticator-id>/connected-appsThe application edit functionality has been updated to allow redirection to the authenticator edit page. Previously, it always redirected to the IDP edit page by default.
IMPORTANT: Currently, the backend functionality related to this improvement is unavailable in the product. PR needs to be merged once the above task is done.
Related Issues
Follow-up Tasks
The source code for the application's authentication functionality needs to be refactored to use generic variable names for connection-related operations. Currently, the variable names are specific to IDPs, but they should be updated to support both IDPs and local authentication.
Checklist
Security checks