Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Custom Authenticator Settings Page #7499

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Shenali-SJ
Copy link
Contributor

@Shenali-SJ Shenali-SJ commented Feb 4, 2025

Purpose

This PR refactors the custom authenticator settings page by extracting the code to a new react component. It also utilizes form spy to handle validations.

settings.mov

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.77%. Comparing base (4502715) to head (54bf5fa).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7499   +/-   ##
=======================================
  Coverage   41.77%   41.77%           
=======================================
  Files          42       42           
  Lines         936      936           
  Branches      235      235           
=======================================
  Hits          391      391           
+ Misses        545      501   -44     
- Partials        0       44   +44     
Flag Coverage Δ
@wso2is/core 41.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@Shenali-SJ Shenali-SJ marked this pull request as draft February 5, 2025 05:59
@Shenali-SJ Shenali-SJ marked this pull request as ready for review February 6, 2025 18:23
@Shenali-SJ Shenali-SJ force-pushed the custom-auth-edit-settings branch from 18b5d41 to cb1b820 Compare February 6, 2025 18:33
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants