Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi email and mobile fields to update with Update button #7513

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

PasinduYeshan
Copy link
Contributor

Previously behavior:

  • Separate patch request was sent when email or mobile number is added or made one of them as primary.

New behavior:

  • Email/mobile addition will be persisted only when Update button is clicked.
Screen.Recording.2025-02-05.at.22.44.42.mov

Related Issues

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.77%. Comparing base (30be807) to head (5a219c2).
Report is 109 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7513      +/-   ##
==========================================
- Coverage   41.98%   41.77%   -0.22%     
==========================================
  Files          42       42              
  Lines         936      936              
  Branches      214      235      +21     
==========================================
- Hits          393      391       -2     
- Misses        543      545       +2     
Flag Coverage Δ
@wso2is/core 41.77% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants