by.timing option

Change the sorting mechanism slightly
xuyiqing · Mar 11, 2019 · a70b30c · a70b30c
1 parent bc99bd4
commit a70b30c
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 35 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: panelView
 Type: Package
 Title: Visualizing Panel Data
-Version: 1.1.1
-Date: 2019-03-10
+Version: 1.1.2
+Date: 2019-03-11
 Author: Licheng Liu, Yiqing Xu
 Maintainer: Yiqing Xu <yiqingxu@ucsd.edu>
 Description: Visualizes panel data. It has two main functionalities: (1) it visualizes the treatment and missing-value statuses of each observation in a panel/time-series-cross-sectional (TSCS) dataset; and (2) it plots the outcome variable (either continuous or discrete) in a time-series fashion.

diff --git a/R/panelView.R b/R/panelView.R
@@ -315,43 +315,37 @@ panelView <- function(data, # a data frame (long-form)
 
         ## once treated, always treated
         D <- apply(D, 2, function(vec){cumsum(vec)})
+        co.total.all <- TT - apply(D, 2, sum)
         D <- ifelse(D > 0, 1, 0)
 
+
         ## timing
-        tr.pos <- which(D[TT,] == 1)
-        ## no.pre.post
-        ## if (pre.post == FALSE) {            
-        ##     D.old.tr <- as.matrix(D.old[,tr.pos])
-        ##     I.tr <- as.matrix(I[,tr.pos])
-        ##     D.old.tr[which(D.old.tr == 0 & I.tr == 1)] <- 1
-        ##     D.old[,tr.pos] <- D.old.tr
-        ##     FEmode <- 1
-        ##     DID <- 0
-        ## } else {
+        tr.pos <- which(D[TT,] == 1) ## which units are treated
         T0 <- apply(D == 0, 2, sum)[tr.pos] ## first time expose to treatment
+        co.total <- co.total.all[tr.pos] ## total number of periods not exposed to treatment 
         DID <- length(unique(T0)) == 1 ## DID type 
 
-        T1 <- t1 <- NULL ## sort by timing
-        if (by.timing == TRUE) {
-
-            T1 <- rep(NA, length(tr.pos))
-
-            for (i in 1:length(tr.pos)) {
-                i.tr <- I[,tr.pos[i]]
-                d.tr <- D.old[,tr.pos[i]]
-                t1 <- which(d.tr == 0 & i.tr == 1)
-                if (length(t1) > 0) {
-                    if (max(t1) <= T0[i]) {
-                        T1[i] <- 0
-                    } else {
-                        T1[i] <- TT - min(t1[which(t1 > T0[i])])
-                    }
-                } else {
-                    T1[i] <- 0
-                }
-            }
 
-        }
+        ## number of periods after first get treated
+        # T1 <- t1 <- NULL ## sort by timing
+        # if (by.timing == TRUE) {
+
+        #     T1 <- rep(NA, length(tr.pos))            
+        #     for (i in 1:length(tr.pos)) {
+        #         i.tr <- I[,tr.pos[i]]
+        #         d.tr <- D.old[,tr.pos[i]]
+        #         t1 <- which(d.tr == 0 & i.tr == 1)
+        #         if (length(t1) > 0) {
+        #             if (max(t1) <= T0[i]) {
+        #                 T1[i] <- 0
+        #             } else {
+        #                 T1[i] <- TT - min(t1[which(t1 > T0[i])])
+        #             }
+        #         } else {
+        #             T1[i] <- 0
+        #         }
+        #     }
+        # }
 
         ## check DID mode
         if (sum(abs(D.old[which(I==1)] - D[which(I==1)])) == 0) {
@@ -1440,9 +1434,9 @@ panelView <- function(data, # a data frame (long-form)
                 if (by.timing == TRUE) {
                     co.seq <- which(unit.type == 1)
                     tr.seq <- setdiff(1:N, co.seq)
-                    dataT0 <- cbind.data.frame(tr.seq, T0, T1)
-                    names(dataT0) <- c("id", "T0", "T1")
-                    dataT0 <- dataT0[order(dataT0[, "T0"], dataT0[, "T1"]),]
+                    dataT0 <- cbind.data.frame(tr.seq, T0, co.total)
+                    names(dataT0) <- c("id", "T0", "co.total")
+                    dataT0 <- dataT0[order(dataT0[, "T0"], dataT0[, "co.total"]),]
                     tr.seq <- dataT0[,"id"]
                     missing.seq <- c(tr.seq, co.seq)