Skip to content

Commit

Permalink
Merge pull request ManageIQ#163 from hayesr/fix_i18n_website
Browse files Browse the repository at this point in the history
Fix i18n page rendering
  • Loading branch information
mzazrivec authored Oct 13, 2016
2 parents fe7ba66 + 69370e8 commit 20e72bc
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions i18n.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,24 @@ we can use `N_()` and `__()` in javascript sources instead of regular `angular-g
There are certain aspects of using `angular-gettext` you should be aware of.

* Be careful where you put the `translate` directive. For example, a markup like:

```html
<div class="outside" translate>
<div class="inside">
<span>Text</span>
</div>
</div>
```
will result into the whole

will result in the whole

```html
<div class="inside">
<span>Text</span>
</div>
```
being collected during string extraction by `gulp gettext-extract`. Correctly, the `translate` directive should be placed inside the `span` element.

block being collected during string extraction by `gulp gettext-extract`. Correctly, the `translate` directive should be placed inside the `span` element.

* Don't use dynamic content inside `__()`. For example, the following javascript code:
```javascript
Expand Down

0 comments on commit 20e72bc

Please sign in to comment.