Update the JS injection demo #4704
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
force-pushed
the
js_injection
branch
from
e1b3191 to
196445d
Compare
kaidokert
force-pushed
the
js_injection
branch
from
e7d5d77 to
3eb9aef
Compare
zhongqiliang
pushed a commit
to zhongqiliang/cobalt
that referenced
this pull request
Jan 17, 2025
Incorporate Chromium's js_injection module into the Chrobalt codebase to enable JavaScript injection capabilities. Move the Kabuki polyfill scripts into cobalt/embedded_resources. Utilize the embed_polyfilled_javascript GN rule to convert the JavaScript files in cobalt/embedded_resources into embedded_js.h. In the CobaltWebContentsObserver constructor, load the embedded JavaScript from embedded_js.h into the GeneratedResourceMap. Use AddDocumentStartJavaScript() to inject the polyfill code into web pages. This ensures the polyfills are executed early in the page lifecycle. Override the RunScriptsAtDocumentStart() method in CobaltContentRendererClient to execute the injected polyfill JavaScript code. This PR is built on top of Kaido 's draft PR youtube#4704. b/384742721
zhongqiliang
added a commit
that referenced
this pull request
Jan 19, 2025
1. Incorporate Chromium's js_injection module into the Chrobalt codebase to enable JavaScript injection capabilities. 2. Move the Kabuki polyfill scripts into cobalt/embedded_resources. 3. Utilize the embed_polyfilled_javascript GN rule to convert the JavaScript files in cobalt/embedded_resources into embedded_js.h. 4. In the CobaltWebContentsObserver constructor, load the embedded JavaScript from embedded_js.h into the GeneratedResourceMap. Use AddDocumentStartJavaScript() to inject the polyfill code into web pages. This ensures the polyfills are executed early in the page lifecycle. 5. Override the RunScriptsAtDocumentStart() method in CobaltContentRendererClient to execute the injected polyfill JavaScript code. This PR is built on top of Kaido 's draft PR #4704. b/384742721 --------- Co-authored-by: Kaido Kert <kaidokert@google.com> Co-authored-by: Colin Liang <colinliang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the example to hook everything up in the appropriate places.
b/379731250