Add support for user on exit strategy. #4757
Conversation
b/385357645
| configuration::Configuration::GetInstance()->CobaltUserOnExitStrategy()); | ||
| if (exit_strategy_str == "stop") { | ||
| return static_cast<UserOnExitStrategy>(kUserOnExitStrategyClose); | ||
| } else if (exit_strategy_str == "suspend") { |
There was a problem hiding this comment.
No need for "else" after return inside the if branch, here and throughout.
I couldn't find a recent source for that style guide entry, only [an old one](https://chromium.googlesource.com/chromium/src.git/+/62.0.3178.1/styleguide/c++/c++.md#code-formatting but that pattern sounds very familiar to me.
| Configuration::Configuration() { | ||
| configuration_api_ = static_cast<const CobaltExtensionConfigurationApi*>( | ||
| SbSystemGetExtension(kCobaltExtensionConfigurationName)); | ||
| if (configuration_api_) { |
There was a problem hiding this comment.
Try and reduce the if-nesting, e.g.
if (!configuration_api_) {
return;
}
// Verify...
| SbSystemGetExtension(kCobaltExtensionConfigurationName)); | ||
| if (configuration_api_) { | ||
| // Verify it's the extension needed. | ||
| if (strcmp(configuration_api_->name, kCobaltExtensionConfigurationName) != |
There was a problem hiding this comment.
Here we use C90 string compare but this is a C++ file, so I'd suggest using like in the other file a if (std::string(configuration_api_->name) == kCobaltExtensionConfigurationName) ....
(std::string::operator== allows direct comparison with C-style strings.)
| // instance as was previously initialized. | ||
| static Configuration* GetInstance(); | ||
|
|
||
| const char* CobaltUserOnExitStrategy(); |
There was a problem hiding this comment.
Can we return a constexpr std::string ? char* can introduce vulnerabilities and bugs.
| ] | ||
| deps = [ | ||
| "//base", | ||
| "//starboard:starboard_headers_only", |
There was a problem hiding this comment.
This should probably fully depend on //starboard:starboard_group
| @@ -107,6 +108,8 @@ void CobaltContentRendererClient::ExposeInterfacesToBrowser( | |||
| void CobaltContentRendererClient::RenderFrameCreated( | |||
| content::RenderFrame* render_frame) { | |||
| new js_injection::JsCommunication(render_frame); | |||
| CobaltRenderFrameObserver* render_frame_observer = | |||
There was a problem hiding this comment.
Where does this get garbage collected?
b/385357645