Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plca update logic #15

Merged
merged 9 commits into from
Mar 13, 2021
Merged

fix: plca update logic #15

merged 9 commits into from
Mar 13, 2021

Conversation

yoyolicoris
Copy link
Owner

fix #14

@yoyolicoris yoyolicoris self-assigned this Mar 12, 2021
@yoyolicoris yoyolicoris marked this pull request as ready for review March 12, 2021 16:57
@yoyolicoris yoyolicoris added bug Something isn't working doing labels Mar 12, 2021
@codecov-io
Copy link

codecov-io commented Mar 12, 2021

Codecov Report

Merging #15 (2eb1539) into master (dce05b2) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   94.23%   94.63%   +0.40%     
==========================================
  Files           7        7              
  Lines         659      671      +12     
==========================================
+ Hits          621      635      +14     
+ Misses         38       36       -2     
Flag Coverage Δ
unittests 94.63% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchnmf/trainer.py 93.63% <ø> (ø)
torchnmf/metrics.py 100.00% <100.00%> (+8.69%) ⬆️
torchnmf/plca.py 96.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce05b2...2eb1539. Read the comment docs.

Copy link
Owner Author

@yoyolicoris yoyolicoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly fixed, should be good to go

@yoyolicoris yoyolicoris merged commit 13e34b2 into master Mar 13, 2021
@yoyolicoris yoyolicoris deleted the 14-plca-fit-alpha-error branch March 13, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working doing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLCA wrong regularization update
2 participants