Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create/Edit Intel module #94

Merged
merged 9 commits into from
Oct 13, 2019
Merged

Add Create/Edit Intel module #94

merged 9 commits into from
Oct 13, 2019

Conversation

mharis001
Copy link
Member

@mharis001 mharis001 commented Aug 4, 2019

When merged this pull request will:

@mharis001 mharis001 added the feature Adds a new feature label Aug 4, 2019
@mharis001 mharis001 added this to the 1.4.0 milestone Aug 4, 2019
CreepPork
CreepPork previously approved these changes Aug 4, 2019
@CreepPork CreepPork self-requested a review August 4, 2019 10:22
@CreepPork
Copy link
Member

CreepPork commented Aug 4, 2019

Don't merge until conversations in #29 are resolved.

@CreepPork
Copy link
Member

Is there a notification for Zeus when they pick up intel?

@mharis001
Copy link
Member Author

The notification is only shown to the units that receive the intel.

@CreepPork
Copy link
Member

A notification for the Zeus'es would be appreciated especially when a lot is going on or you are building something else and you need to kickstart a different stage of the mission.

@mharis001
Copy link
Member Author

Will leave issue open, can look at further enhancements later in order to merge for 1.5.0.

addons/modules/stringtable.xml Outdated Show resolved Hide resolved
@mharis001 mharis001 merged commit b538b50 into master Oct 13, 2019
@mharis001 mharis001 deleted the intel-module branch October 13, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants