Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: doc: clear cloudfront cache when publishing docs to S3 #83812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: doc: clear cloudfront cache when publishing docs to S3 #83812

wants to merge 1 commit into from
+4 −0

Conversation

kartben
Copy link
Collaborator

@kartben kartben commented Jan 10, 2025

In order to make sure we never too aggressively cache documentation files, make sure deployment to S3 is followed by an explicit full cache invalidation of the URLs the files are being served from.

@kartben
ci: doc: clear cloudfront cache when publishing docs to S3
9a392ca 
In order to make sure we never too aggressively cache documentation
files, make sure deployment to S3 is followed by an explicit full
cache invalidation of the URLs the files are being served from.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben marked this pull request as ready for review January 10, 2025 13:05
@kartben
Copy link
Collaborator Author

kartben commented Jan 10, 2025 •
edited
Loading

I've tested with my local aws client that the two added commands are working as expected and correctly create the invalidation

image

henrikbrixandersen
henrikbrixandersen approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nashif
nashif requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will not work, the token used for AWS does not have permissions to modify cloudfront. We probably want to do this in AWS directly instead of a workflow. We probably do not want to give aws client more power here given how workflows can be abused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nashif nashif nashif requested changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

@stephanosio stephanosio Awaiting requested review from stephanosio

Requested changes must be addressed to merge this pull request.

Assignees

@nashif nashif

@stephanosio stephanosio

Labels
area: Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kartben @nashif @henrikbrixandersen @stephanosio @zephyrbot