Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax block_on top level function to accept IntoFuture #26

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

tisonkun
Copy link
Contributor

This would increase the MSRV to 1.64.0.

I don't know what is the MSRV of this project now and how can I find it.

cc @zesterer

@zesterer
Copy link
Owner

Thanks! I've not actually decided on a hard policy yet, and have just avoided anything that would have needed an MSRV nudge.

Something I'm considering is an '18 months' policy, which would require us to compile on 1.69. This is no accident: 1.68 introduced the pin! macro, which would permit us to remove the only unsafe code in the crate. What do you think about this?

@tisonkun
Copy link
Contributor Author

What do you think about this?

  1. It's reasonable to bump to 1.69.
  2. It would be nice to add MSRV meta info at:

Hopefully these help.

@tisonkun
Copy link
Contributor Author

For policy, here is a reference: https://github.com/tisonkun/cronexpr?tab=readme-ov-file#minimum-rust-version-policy

@zesterer zesterer merged commit d58d154 into zesterer:master Oct 26, 2024
2 checks passed
@tisonkun tisonkun deleted the patch-1 branch October 27, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants