Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

West Midlands | Alireza Seifi Shalamzari | Module-Data-Flows | Book Library #149

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

West Midlands | Alireza Seifi Shalamzari | Module-Data-Flows | Book Library #149

wants to merge 4 commits into from

Conversation

Alireza1620
Copy link

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

This PR should fix the Last PR for Book Library.

Questions

Ask any questions you have for your reviewer.

@Alireza1620
Update index.html and add title, and change the oncall from submit() …
b3a5048 
…to addBook()

Since in script file we have a function called submit() and a variable called the same, it can cause bugs in future
@Alireza1620
Update script.js and Fix the logic for PopulateStorage()
2a9e2dd 
If the function calles the render() it will cause a bug
@Alireza1620
Update script.js and fix the submit function
7dd5aa9
@Alireza1620 Alireza1620 requested a review from cjyuan January 17, 2025 12:26
@Alireza1620 Alireza1620 added the Needs Review Participant to add when requesting review label Jan 17, 2025
@Alireza1620 Alireza1620 mentioned this pull request Jan 17, 2025
Open
@Alireza1620 Alireza1620 changed the title West Midlands | Alireza Seifi Shalamzari | Module-Data-Flows | Week 2 West Midlands | Alireza Seifi Shalamzari | Module-Data-Flows | Book Library Jan 17, 2025
cjyuan
cjyuan reviewed Jan 17, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you try loading the page in a browser?
I don't think the script will run properly because it still has syntax errors that still need to be fixed.

@cjyuan cjyuan added 👀 Review Requirements Changes requested to meet requirements Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jan 17, 2025
@Alireza1620
Copy link
Author

Have you try loading the page in a browser? I don't think the script will run properly because it still has syntax errors that still need to be fixed.

Please Check now

cjyuan
cjyuan reviewed Jan 17, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All bugs described in readme.md have been fixed. Feel free to mark this as completed.

Note: There are also some errors in index.html.

debugging/book-library/script.js
Comment on lines +77 to 79
alert(`You've deleted the title: ${book.title}`);
myLibrary.splice(index, 1);
render();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment when the alert message is displayed, has the book mentioned in the message been deleted yet?
How would you rearrange these statements to make the message truthful?

@cjyuan cjyuan removed the 👀 Review Requirements Changes requested to meet requirements label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alireza1620 @cjyuan