Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

West Midlands | Alireza Seifi Shalamzari | Module-Data-Flows | Book Library #149

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

West Midlands | Alireza Seifi Shalamzari | Module-Data-Flows | Book Library #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3a5048
Update index.html and add title, and change the oncall from submit() …
Alireza1620 Jan 17, 2025
2a9e2dd
Update script.js and Fix the logic for PopulateStorage()
Alireza1620 Jan 17, 2025
7dd5aa9
Update script.js and fix the submit function
Alireza1620 Jan 17, 2025
b0e1292
Update script.js and fix the minor bugs
Alireza1620 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<title>Book Libray</title>
<meta
charset="utf-8"
name="viewport"
Expand Down Expand Up @@ -65,7 +65,7 @@ <h1>Library</h1>
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
onclick="addBook();"
/>
</div>
</div>
Expand Down
100 changes: 40 additions & 60 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,10 @@ window.addEventListener("load", function (e) {
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
if (myLibrary.length === 0) {
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true);
myLibrary.push(book1, book2);
}
}

Expand All @@ -27,20 +20,20 @@ const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
function addBook() {
if (!title.value || !author.value || !pages.value) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}

let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
// Clear form
title.value = "";
author.value = "";
pages.value = "";
check.checked = false;
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +44,40 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let table = document.getElementById("display").getElementsByTagName("tbody")[0];
table.innerHTML = ""; // Clear table

myLibrary.forEach((book, index) => {
let row = table.insertRow();
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
// Read/Unread toggle button
let readButton = document.createElement("button");
readButton.className = "btn btn-success";
readButton.textContent = book.check ? "Yes" : "No";
readButton.addEventListener("click", function () {
book.check = !book.check;
render();
});
wasReadCell.appendChild(readButton);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
// Delete button
let deleteButton = document.createElement("button");
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";
deleteButton.addEventListener("click", function () {
alert(`You've deleted the title: ${book.title}`);
myLibrary.splice(index, 1);
render();
Comment on lines +77 to 79
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment when the alert message is displayed, has the book mentioned in the message been deleted yet?
How would you rearrange these statements to make the message truthful?

});
}
deleteCell.appendChild(deleteButton);
});
}