Add option to select tiledb core source tarball for download #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl,
awenocur,
mojaveazure and
teo-tsirpanis
|
This pull request has been linked to Shortcut Story #37639: Several smaller enhancements and extension to the R package build. |
awenocur
approved these changes
Nov 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers some small updates to the build system that go along with with #620 , #621 and the TileDB Core changes for
vcpkg. We now ensure / check thatcurlis installed (asvcpkgneeds it) and support aconfigureoption--with-download=urlto supply a URL (the option itself may have come in with #620) for which theurlargument, when given, is passed on to the worker scripts managing the download. The fallback remains the pinned default version, but a given url could e.g. point to nighly tarballs (once produced).