Add support for aggregates #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl,
awenocur,
mojaveazure and
KiterLuc
|
This pull request has been linked to Shortcut Story #36024: Support aggregates now being added to 2.18. |
awenocur
approved these changes
Nov 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (initial) support for aggregates, namely
Count,NullCount,Min,Max,MeanandSum. Unit tests have been added as well.The branch had been rebased a few times to the timestamps on the commits are not accurate. There was an initial commit several weeks ago followed by refinement this week.
And a propos of nothing, CI started to have a fit this afternoon not getting the Windows artifact to the download time limit was increased for all three affected scripts from 60s to 180s. Should not be material during normal times, yet also not hurt as a simple upper limit.