Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes executor watcher kube_client_request_args shadowing #45528

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

insomnes
Copy link
Contributor

@insomnes insomnes commented Jan 9, 2025

Fix KubernetesJobWatcher shadowing kube client timeouts arguments

Provided change allows to have previously established defaults in KubernetesJobWatcher for client timeouts to not hang on events reading, but also do not overwrite them if they were provided in specific configuration option by user.

closes: #45517


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jan 9, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@insomnes insomnes force-pushed the kexec-watcher-req-args branch 2 times, most recently from 4c73b7c to d62734a Compare January 10, 2025 07:56
@insomnes insomnes force-pushed the kexec-watcher-req-args branch from d62734a to 3177e52 Compare January 10, 2025 15:41
@insomnes
Copy link
Contributor Author

I've checked failed tests in previous checks run
https://github.com/apache/airflow/actions/runs/12698225501

And I can't find any reason for my changes to interfere with them. So I've rebased branch again

Copy link
Contributor

@RNHTTR RNHTTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to set the placeholder vars

…rnetes_executor_utils.py


Apply suggestion by review

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
@insomnes
Copy link
Contributor Author

Added as suggested. I am not familiar with code standards, so I was trying to minimize my "invasion".

Thank you!

@potiuk potiuk merged commit 3c63bb6 into apache:main Jan 13, 2025
71 checks passed
Copy link

boring-cyborg bot commented Jan 13, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@insomnes insomnes deleted the kexec-watcher-req-args branch January 13, 2025 17:01
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 13, 2025
…pache#45528)

* Fix watcher kube_client_request_args shadowing

* Update providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py

Apply suggestion by review

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>

---------

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jan 13, 2025
…pache#45528)

* Fix watcher kube_client_request_args shadowing

* Update providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py

Apply suggestion by review

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>

---------

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
…pache#45528)

* Fix watcher kube_client_request_args shadowing

* Update providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py

Apply suggestion by review

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>

---------

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
…pache#45528)

* Fix watcher kube_client_request_args shadowing

* Update providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py

Apply suggestion by review

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>

---------

Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubernetesExecutor shadowing timeout_seconds and _request_seconds
3 participants