Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes executor watcher kube_client_request_args shadowing #45528

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Fix kubernetes executor watcher kube_client_request_args shadowing #45528

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3177e52
Fix watcher kube_client_request_args shadowing
insomnes Jan 9, 2025
f9f083f
Update providers/src/airflow/providers/cncf/kubernetes/executors/kube…
insomnes Jan 10, 2025
4868dc8
Merge branch 'main' into kexec-watcher-req-args
RNHTTR Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,12 @@ def _run(
# For info about k8s timeout settings see
# https://github.com/kubernetes-client/python/blob/v29.0.0/examples/watch/timeout-settings.md
# and https://github.com/kubernetes-client/python/blob/v29.0.0/kubernetes/client/api_client.py#L336-L339
client_timeout = 30
server_conn_timeout = 3600
kwargs["_request_timeout"] = client_timeout
kwargs["timeout_seconds"] = server_conn_timeout
if "_request_timeout" not in kwargs:
client_timeout = 30
kwargs["_request_timeout"] = client_timeout
if "timeout_seconds" not in kwargs:
server_conn_timeout = 3600
kwargs["timeout_seconds"] = server_conn_timeout
insomnes marked this conversation as resolved.
Show resolved Hide resolved

logical_date_key = get_logical_date_key()
for event in self._pod_events(kube_client=kube_client, query_kwargs=kwargs):
Expand Down
Loading