Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireframeMaterial and Wireframe2dMaterial don't derive Reflect #17474

Open
anlumo opened this issue Jan 21, 2025 · 0 comments
Open

WireframeMaterial and Wireframe2dMaterial don't derive Reflect #17474

anlumo opened this issue Jan 21, 2025 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@anlumo
Copy link
Contributor

anlumo commented Jan 21, 2025 •
edited
Loading

What problem does this solve or what need does it fill?

There are three types implementing Material in bevy:

  • StandardMaterial
  • ExtendedMaterial
  • WireframeMaterial

The former two implement Reflect, while the latter does not. I think this is an oversight.

The same is true for Material2d:

  • ColorMaterial derives Reflect, while
  • Wireframe2dMaterial does not.

What solution would you like?

Since the fields of WireframeMaterial and Wireframe2dMaterial are rather trivial, a simple #[derive(Reflect)] should be enough, mirroring StandardMaterial and ColorMaterial.

What alternative(s) have you considered?

Just don't support WireframeMaterial, but I think it'd be good for debugging purposes.
@anlumo anlumo added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jan 21, 2025
@anlumo anlumo changed the title bevy::pbr::wireframe::WireframeMaterial doesn't derive Reflect WireframeMaterial and Wireframe2dMaterial don't derive Reflect Jan 21, 2025
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jan 21, 2025
@BenjaminBrienen BenjaminBrienen mentioned this issue Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anlumo @alice-i-cecile